Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary parenthesis added in long assert statements #843

Closed
zsol opened this issue May 8, 2019 · 1 comment
Closed

Unnecessary parenthesis added in long assert statements #843

zsol opened this issue May 8, 2019 · 1 comment
Labels
F: parentheses Too many parentheses, not enough parentheses, and so on.

Comments

@zsol
Copy link
Collaborator

zsol commented May 8, 2019 

-        assert looooooooooooooooooooong in { looooooooooooooooooooooooooooooooooooooooooooooooooooooong}, "wot. a bug?!" % loooooooong
+        assert looooooooooooooooooooong in {
+            looooooooooooooooooooooooooooooooooooooooooooooooooooooong
+        }, ("wot. a bug?!" % loooooooong)
@zsol zsol added T: bug Something isn't working F: parentheses Too many parentheses, not enough parentheses, and so on. and removed T: bug Something isn't working labels May 8, 2019
@ambv ambv added this to To do in AST-unsafe changes May 9, 2019
@ambv ambv removed this from To do in AST-unsafe changes May 9, 2019
@felix-hilden
Copy link
Collaborator

With experimental string processing, this currently produces:

assert looooooooooooooooooooong in {
    looooooooooooooooooooooooooooooooooooooooooooooooooooooong
}, "wot. a bug?!" % loooooooong

So I think this issue can be closed. See this comment and #2188

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
F: parentheses Too many parentheses, not enough parentheses, and so on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zsol @felix-hilden