New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vertical method chaining #4244

Open

rat-nick opened this issue Feb 19, 2024 · 0 comments

Labels

T: style

rat-nick commented Feb 19, 2024 •

edited

When chaining multiple methods together as such:

def f():
    data = item_preprocessor \
        .handle_missing_values(strategy="mean") \
        .multilabel_binarize(["tags"]) \
        .normalize(["price"], methods=["z-score"]) \
        .onehot_encode(categorical_columns=["category"]) \
        .select_features(regex="^ftr.*", columns=["price"])

Black formats as such:

def f():
    data = (
        item_preprocessor.handle_missing_values(strategy="mean")
        .multilabel_binarize(["tags"])
        .normalize(["price"], methods=["z-score"])
        .onehot_encode(categorical_columns=["category"])
        .select_features(regex="^ftr.*", columns=["price"])
    )

It seems more readable as the first method being chained has its own line

def f():
    data = (
        item_preprocessor
        .handle_missing_values(strategy="mean")
        .multilabel_binarize(["tags"])
        .normalize(["price"], methods=["z-score"])
        .onehot_encode(categorical_columns=["category"])
        .select_features(regex="^ftr.*", columns=["price"])
    )

rat-nick added the T: style label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment