Latest docker images fail with an ImportError

[ravishi]

Describe the bug

I'm on MacOS. I try to run Black through Docker, but the container promptly stops with an ImportError related to the missing aiohttp dep.

To Reproduce

docker run -d -p 45484:45484 --pull always pyfound/black blackd --bind-host 0.0.0.0
# returns c42cfd39d8047d840beb779ea529005ef4d5682b060bcbca9b154e940bd346ab

docker logs -f c42cfd39d8047d840beb779ea529005ef4d5682b060bcbca9b154e940bd346ab
Traceback (most recent call last):
  File "/opt/venv/bin/blackd", line 5, in <module>
    from blackd import patched_main
  File "/opt/venv/lib/python3.12/site-packages/blackd/__init__.py", line 14, in <module>
    raise ImportError(
ImportError: aiohttp dependency is not installed: No module named 'aiohttp'. Please re-install black with the '[d]' extra install to obtain aiohttp_cors: `pip install black[d]`

• Black's version: Any tag greater than pyfound/black:23.10.0
• OS and Python version: [MacOS/14.2.1 (23C71)]

[cooperlees]

Howdy

We've on purpose never built the docker image with the [d] extra dependencies to keep the images as small as possible.

We could add this in - But I want to see what people prefer:

• Add by default and make the image smaller (I have not calculated the size - But I expect it to be a small different)
  • Simple, but everyone occurs the size increase even if not using blackd
  • Image is currently around 55MB
  • aiohttp wheels seem to be around 1.5MB (but that's zip compressed)
• Add a dedicated built for a extra [d] install and make new tags
  • A lot more complicated and more things to potentially fix in the future

Thoughts all?

[cooperlees]

Actually, I am wrong, we do try to do the extra install:

https://github.com/psf/black/blob/main/Dockerfile#L13

I will look into it - But if anyone has time, PR welcoming fixing getting aiohttp into the container.

• I would have expected it to be in the venv we copy over from the build container ...

[JelleZijlstra]

I haven't delved into the history, but might be worth looking at what we changed in 23.10. Could be a Hatch bug; this reminds me of #4107 which is sort of the opposite.