Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash with walrus + await + with #3473

Merged
merged 5 commits into from Jan 18, 2023
Merged

Conversation

JelleZijlstra
Copy link
Collaborator

Fixes #3472

@github-actions
Copy link

github-actions bot commented Dec 25, 2022

diff-shades reports zero changes comparing this PR (cbcee44) to main (d4ff985).


What is this? | Workflow run | diff-shades documentation

Copy link
Collaborator

@ichard26 ichard26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'd double check the test data file. I don't think it's testing what you want.

tests/data/py_38/pep_572_remove_parens.py Show resolved Hide resolved
@JelleZijlstra JelleZijlstra merged commit 7e6d3fa into psf:main Jan 18, 2023
@JelleZijlstra JelleZijlstra deleted the main branch January 18, 2023 06:25
@JelleZijlstra JelleZijlstra restored the main branch January 18, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preview style: Crash on walrus in with statement
3 participants