Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a crash in ESP where a standalone comment is placed before a dict's value. #3469

Merged
merged 1 commit into from Dec 20, 2022
Merged

Fix a crash in ESP where a standalone comment is placed before a dict's value. #3469

merged 1 commit into from Dec 20, 2022

Conversation

yilei
Copy link
Contributor

@yilei yilei commented Dec 20, 2022

Description

Fixes #3455.

The resulted formatting is the same as current stable, and making the result nicer is out of ESP's scope.

Checklist - did you ...

  • Add an entry in CHANGES.md if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

@github-actions
Copy link

diff-shades reports zero changes comparing this PR (ddf3464) to main (a44dc3d).

What is this? | Workflow run | diff-shades documentation

@JelleZijlstra JelleZijlstra merged commit 73c2d55 into psf:main Dec 20, 2022
hugovk pushed a commit to hugovk/black that referenced this pull request Jan 16, 2023
@yilei @hugovk
Fix a crash in ESP where a standalone comment is placed before a dict…
77a0779 
…'s value (psf#3469)
@yilei yilei deleted the espcrash branch January 24, 2023 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Black --preview crashes on long dict key followed by a comment line
2 participants
@yilei @JelleZijlstra