Exclude string type annotations from ESP #3462
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR excludes string type annotations from ESP, and also fixes crash on mismatched brackets from ESP.
Even though other type checkers (mypy, pytype, pyre) do support them. To be safe, we can choose to exclude them from ESP for now. Note we could technically choose to try merging them into a single string when the result fits in the line-length, but this would be more complicated than simply excluding them from ESP.
The line can be
) -> "VeryLongClassNameWithAwkwardGenericSubtype[int] |VeryLongClassNameWithAwkwardGenericSubtype[str]":
while processing. This PR makesBracketTracker.mark
accept unmatched closing brackets.Fixes #3435. Fixes #3457.
Checklist - did you ...
CHANGES.md
if necessary?