Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix two docstring crashes #3451

Merged
merged 4 commits into from Jan 16, 2023
Merged

Fix two docstring crashes #3451

merged 4 commits into from Jan 16, 2023

Conversation

JelleZijlstra
Copy link
Collaborator

@JelleZijlstra JelleZijlstra commented Dec 19, 2022 •
edited

Fixes #3425. Fixes #3427.

@JelleZijlstra
Add test for crasher psf#3425
5ea8938 
The crash reproes on 22.12.1 but appears to be fixed on main; add
a test to make sure.
@JelleZijlstra JelleZijlstra added the skip news Pull requests that don't need a changelog entry. label Dec 19, 2022
@JelleZijlstra JelleZijlstra changed the title Add test for crasher #3425 Fix two docstring crashes Dec 19, 2022
@github-actions
Copy link

github-actions bot commented Dec 19, 2022 •
edited

diff-shades reports zero changes comparing this PR (a477ec7) to main (d4ff985).

What is this? | Workflow run | diff-shades documentation

JelleZijlstra
JelleZijlstra commented Dec 20, 2022
View reviewed changes
tests/test_format.py Outdated Show resolved Hide resolved
@ichard26 ichard26 self-requested a review January 14, 2023 18:39
cooperlees
cooperlees approved these changes Jan 16, 2023
View reviewed changes
Copy link
Collaborator

@cooperlees cooperlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic seems sane when we add what space to set the bool + use. Tests are good and make sense.

Will leave it to you to rebase or I can to merge?

@JelleZijlstra
Copy link
Collaborator Author

Thanks, just fixed the merge.

@JelleZijlstra JelleZijlstra merged commit 60a2e8e into psf:main Jan 16, 2023
@JelleZijlstra JelleZijlstra deleted the test3425 branch January 16, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cooperlees cooperlees cooperlees approved these changes

@ichard26 ichard26 Awaiting requested review from ichard26

Assignees
No one assigned
Labels
skip news Pull requests that don't need a changelog entry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash with line-length 6 and multi-line docstring Crash with line-length 18 and backslash in docstring
2 participants
@JelleZijlstra @cooperlees