Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash in preview style with assert + parenthesized string #3414

Closed
JelleZijlstra opened this issue Dec 10, 2022 · 1 comment · Fixed by #3415
Closed

Crash in preview style with assert + parenthesized string #3414

JelleZijlstra opened this issue Dec 10, 2022 · 1 comment · Fixed by #3415
Labels
C: crash Black is crashing F: trailing comma Full of magic T: bug Something isn't working

Comments

@JelleZijlstra
Copy link
Collaborator 

assert xxxxxxxxx.xxxxxxxxx.xxxxxxxxx(
    xxxxxxxxx
).xxxxxxxxxxxxxxxxxx(), (
    "xxx {xxxxxxxxx} xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx"
)

Running black --preview on this file results in error: cannot format xxxxxx.py: Unable to match a closing bracket to the following opening bracket: .

This is a regression in 22.12.0. It bisects to #3370, cc @yilei.
@JelleZijlstra JelleZijlstra added T: bug Something isn't working C: crash Black is crashing F: trailing comma Full of magic labels Dec 10, 2022
@JelleZijlstra JelleZijlstra mentioned this issue Dec 10, 2022
Closed
@yilei
Copy link
Contributor

yilei commented Dec 10, 2022

Thanks for the cc, I'll take a look!

@yilei yilei mentioned this issue Dec 10, 2022
Merged
3 tasks
JelleZijlstra pushed a commit that referenced this issue Dec 10, 2022
@yilei
Fix a crash in preview style with assert + parenthesized string. (#3415)
96e62c5 
The bug is in the `get_leaves_inside_matching_brackets` on the third line below:

```python
assert xxxxxxxxx.xxxxxxxxx.xxxxxxxxx(
    xxxxxxxxx
).xxxxxxxxxxxxxxxxxx(), (
    "xxx {xxxxxxxxx} xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx"
)
```

Including the invisible paren, third line is `).xxxxxxxxxxxxxxxxxx()), (`, that it has a matched pair then an unmatched closing paren afterwards. This PR ensures the returned leaves are actually matched.

Fixes #3414.
@intgr intgr mentioned this issue Dec 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: crash Black is crashing F: trailing comma Full of magic T: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix a crash in preview style with assert + parenthesized string. yilei/black
2 participants
@yilei @JelleZijlstra