string_processing: Ugly reformatting of string literal with .format() method

[JelleZijlstra]

% cat quash.py 
class X:
    def generate_shared_lib_init(self) -> None:
        emitter.emit_lines(
            "{",
            (
                'static PyModuleDef def = {{ PyModuleDef_HEAD_INIT, "{}", NULL, -1, NULL, NULL }};'.format(
                    shared_lib_name(self.group_name)
                )
            ),
        )
% black --preview --diff quash.py
--- quash.py	2022-12-09 03:02:23.973269 +0000
+++ quash.py	2022-12-09 03:03:57.327044 +0000
@@ -1,10 +1,7 @@
 class X:
     def generate_shared_lib_init(self) -> None:
         emitter.emit_lines(
             "{",
-            (
-                'static PyModuleDef def = {{ PyModuleDef_HEAD_INIT, "{}", NULL, -1, NULL, NULL }};'.format(
-                    shared_lib_name(self.group_name)
-                )
-            ),
+            'static PyModuleDef def = {{ PyModuleDef_HEAD_INIT, "{}", NULL, -1, NULL, NULL }};'
+            .format(shared_lib_name(self.group_name)),
         )
would reformat quash.py

All done! ✨ 🍰 ✨
1 file would be reformatted.

I like the old code better so I wouldn't want stable style to start behaving like this (ref. #3407).

[felix-hilden]

I'll disagree for this particular case: it's two lines and one nesting level less, and having "format" on a separate line avoids having to scan at the end of the previous line. But it seems to be formatted differently depending on the line length (playground):

class X:
    def generate_shared_lib_init(self) -> None:
        emitter.emit_lines(
            "{",
            'static PyModuleDef def = {{ PyModuleDef_HEAD_INIT, "{}", NULL, -1, NULL,'
            " NULL }};".format(shared_lib_name(self.group_name)),
        )

Not so sure about that one, especially since we now put implicitly concatenated strings in parens elsewhere (also in the playground example):

call(
    a,
    (
        "static PyModuleDefwithmorestringnesstopadoutthelinelength def = {{"
        " PyModuleDef_HEAD_INIT,{}, NULL, -1, NULL, NULL }};"
    ),
    b,
)