Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vim plugin: allow using system black rather than virtualenv #3309

Merged
merged 1 commit into from Oct 27, 2022
Merged

Vim plugin: allow using system black rather than virtualenv #3309

merged 1 commit into from Oct 27, 2022

Conversation

bugfood
Copy link
Contributor

@bugfood bugfood commented Oct 4, 2022

Provide a configuration parameter to the Vim plugin which will allow the plugin to skip setting up a virtualenv. This is useful when there is a system installation of black (e.g. from a Linux distribution) which the user prefers to use.

Using a virtualenv remains the default.

Description

I have several reasons why using a virtualenv is undesirable to me. I have listed them in the following feature request.
Fixes: #3308

Checklist - did you ...

  • [Y] Add an entry in CHANGES.md if necessary?
  • [N/A?] Add / update tests if necessary?
  • [Y] Add new / update outdated documentation?

Thanks,
Corey

Copy link
Collaborator

@felix-hilden felix-hilden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, some comments below!

docs/integrations/editors.md Outdated Show resolved Hide resolved
docs/integrations/editors.md Outdated Show resolved Hide resolved
Provide a configuration parameter to the Vim plugin which will allow the
plugin to skip setting up a virtualenv. This is useful when there is a
system installation of black (e.g. from a Linux distribution) which the
user prefers to use.

Using a virtualenv remains the default.

- Fixes #3308
@bugfood
Copy link
Contributor Author

bugfood commented Oct 27, 2022

@felix-hilden (or anyone) is there anything I need to do to get this PR merged? So far, I don't think there are any objections.

Thanks,
Corey

Copy link
Collaborator

@cooperlees cooperlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, felix approved, but I have very little vim plugin skill ... #blindMerge

@cooperlees cooperlees merged commit 4bb6e4f into psf:main Oct 27, 2022
@bugfood
Copy link
Contributor Author

bugfood commented Oct 28, 2022

Thank you.

@naught101
Copy link

To use this, add this to your .vimrc:

let g:black_use_virtualenv = 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

please support use of the system black installation
4 participants