Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests with minimum versions of dependencies installed #2795

Open
ichard26 opened this issue Jan 22, 2022 · 2 comments
Open

Run tests with minimum versions of dependencies installed #2795

ichard26 opened this issue Jan 22, 2022 · 2 comments
Labels
C: maintenance Related to project maintenance, e.g. CI, testing, policy changes, releases

Comments

@ichard26
Copy link
Collaborator

Follow-up from #2791 and #2774, we should add a step to the test workflow which runs the test suite again but with the lowest supported dependencies installed. Unfortunately there doesn't really seem to be good tooling for this (short of https://github.com/ffy00/python-resolver#mindeps-cli) so this may be blocked until such tooling exists or we could take the cheap to implement / more expensive down the road route of defining a constraints file that manually pins the dependencies to the lowest versions supported.

We could run diff-shades/primer against the minimum dependencies but I'm wary of the CI time increases. Especially as it's unlikely an older version of a dependency would cause a subtle issue with formatting (given the core formatting logic is all our own) that these sorts of jobs discover.

@ichard26 ichard26 added the C: maintenance Related to project maintenance, e.g. CI, testing, policy changes, releases label Jan 22, 2022
@JelleZijlstra
Copy link
Collaborator

Thanks! I agree primer is overkill; our dependencies are unlikely to affect formatting since the core formatting logic doesn't use any dependencies.

@hauntsaninja
Copy link
Collaborator

There's https://pypi.org/project/pessimist/ but I don't have direct experience with using it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: maintenance Related to project maintenance, e.g. CI, testing, policy changes, releases
Projects
None yet
Development

No branches or pull requests

3 participants