Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Black does not like white backgroud #2688

Closed
csotto opened this issue Dec 14, 2021 · 5 comments
Closed

Black does not like white backgroud #2688

csotto opened this issue Dec 14, 2021 · 5 comments
Labels
S: accepted The changes in this design / enhancement issue have been accepted and can be implemented S: awaiting response Waiting for futher information from OP T: bug Something isn't working

Comments

@csotto
Copy link

csotto commented Dec 14, 2021

Describe the bug

To Reproduce

For example, take this code:

this = "code"

And run it with these arguments:

$ black file.py --target-version py39

The resulting error is:

cannot format file.py: INTERNAL ERROR: ...

Expected behavior

Environment

  • Black's version:
  • OS and Python version:

Additional context

@csotto csotto added the T: bug Something isn't working label Dec 14, 2021
@csotto
Copy link
Author

csotto commented Dec 14, 2021

I prefer white background on terminals.
Running Black ( black-21.12b0 ) on W10 Git terminal (MINGW64) configured with white background (255, 255, 255) results in a unreadable result message. (white letters over white background.

@JelleZijlstra
Copy link
Collaborator

What exactly is the error you are getting?

@ichard26
Copy link
Collaborator

image

Assuming your colour padlette is configured properly it should be fine given we don't set any specific colours other than blue, yellow, green, and red.. although as I write that I do see our diff header is unreadable.
image

@ichard26 ichard26 added the S: accepted The changes in this design / enhancement issue have been accepted and can be implemented label Dec 14, 2021
@ichard26 ichard26 added the S: awaiting response Waiting for futher information from OP label Dec 16, 2021
@ichard26
Copy link
Collaborator

Hi @csotto, did we resolve your issue via GH-2691 or do you have another issue to report?

@ichard26
Copy link
Collaborator

It's been two weeks so I'm going to close this issue as I can't tell what else would be broken on light-themed terminals after GH-2691. If Black is still broken for ya lemme know and I'll be happy to reopen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: accepted The changes in this design / enhancement issue have been accepted and can be implemented S: awaiting response Waiting for futher information from OP T: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants