Assignment to env var in Jupyter Notebook doesn't round-trip #2642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
force-pushed
the
assign-to-env-var
branch
from
082b84e
to
6dbef34
Compare
MarcoGorelli
force-pushed
the
assign-to-env-var
branch
from
6dbef34
to
3ca6f06
Compare
MarcoGorelli
changed the title
src/black/handle_ipynb_magics.py
Outdated
| elif node.value.func.attr == "run_line_magic": | ||
| src = f"%{args[0]}" | ||
| if args[1]: | ||
| assert src is not None |
There was a problem hiding this comment.
Does mypy need this? It's assigned to a str just above.
There was a problem hiding this comment.
Indeed, it's not necessary - thanks!
JelleZijlstra
approved these changes
Nov 26, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist - did you ...
closes #2641