Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump regex dependency to 2021.4.4 to fix import of Pattern class #2621

Merged
merged 3 commits into from Nov 18, 2021

Conversation

rowanseymour
Copy link
Contributor

Fixes #2620

Copy link
Collaborator

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JelleZijlstra
Copy link
Collaborator

Could you add a changelog entry? I'm leaning towards making a new release for this, so we should announce the change.

@JelleZijlstra
Copy link
Collaborator

People on Discord brought up that we also need to update Pipfile.lock.

CHANGES.md Outdated Show resolved Hide resolved
@rowanseymour
Copy link
Contributor Author

@JelleZijlstra took a few goes to figure out pipenv locking but I think I have it right now..

Copy link
Collaborator

@ichard26 ichard26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pipenv is a pain but this looks good enough? Thank you for noticing the original issue by the way @rowanseymour!

@JelleZijlstra JelleZijlstra merged commit ecf8c74 into psf:main Nov 18, 2021
@rowanseymour
Copy link
Contributor Author

thanks for freeing us from worrying about how format python!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

21.11b01 release broken with older versions of regex
3 participants