Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed distutils import from autoload/black.vim (#2607) #2610

Merged
merged 7 commits into from Nov 15, 2021
Merged

Removed distutils import from autoload/black.vim (#2607) #2610

merged 7 commits into from Nov 15, 2021

Conversation

515k4
Copy link
Contributor

@515k4 515k4 commented Nov 14, 2021 •
edited

Description

Fixed #2607 by removing distutils import from autoload/black.vim, which is deprecated in Python 3.10, and by re-implementing the distutils.strtobool as suggested in PEP 632.

Checklist

  • Add a CHANGELOG entry if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

JelleZijlstra
JelleZijlstra requested changes Nov 14, 2021
View reviewed changes
Copy link
Collaborator

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Could you also add a changelog entry?

autoload/black.vim Outdated Show resolved Hide resolved
JelleZijlstra
JelleZijlstra reviewed Nov 14, 2021
View reviewed changes
CHANGES.md Outdated Show resolved Hide resolved
515k4 and others added 2 commits November 14, 2021 16:24
@515k4 @JelleZijlstra
Update CHANGES.md
5f4543d 
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@515k4
Two-space indents and f-string (psf#2607)
3a53782
JelleZijlstra
JelleZijlstra reviewed Nov 14, 2021
View reviewed changes
CHANGES.md Outdated Show resolved Hide resolved
@JelleZijlstra JelleZijlstra merged commit 78317a4 into psf:main Nov 15, 2021
@JelleZijlstra
Copy link
Collaborator

Thanks!

@515k4 515k4 deleted the removed-distutils branch November 15, 2021 19:35
@matthewarmand matthewarmand mentioned this pull request Dec 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vim plugin fail with Python 3.10 due to importing distutils in autoload/black.vim
2 participants
@515k4 @JelleZijlstra