Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address mypy errors on 3.10 w/ asyncio loop parameter #2580

Merged
merged 1 commit into from Oct 30, 2021
Merged

Address mypy errors on 3.10 w/ asyncio loop parameter #2580

merged 1 commit into from Oct 30, 2021

Conversation

ichard26
Copy link
Collaborator

Description

Somehow we didn't notice that the loop parameter was removed in the various asyncio high-level APIs in 3.10 :p

Checklist - did you ...

  • Add a CHANGELOG entry if necessary?
  • Add / update tests if necessary? -> n/a
  • Add new / update outdated documentation? -> n/a

JelleZijlstra
JelleZijlstra approved these changes Oct 30, 2021
View reviewed changes
Copy link
Collaborator

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it

@JelleZijlstra JelleZijlstra merged commit 9afffac into psf:main Oct 30, 2021
@ichard26 ichard26 deleted the asyncio-loop branch October 30, 2021 22:37
JelleZijlstra pushed a commit that referenced this pull request Nov 16, 2021
@ichard26 @JelleZijlstra
Address mypy errors on 3.10 w/ asyncio loop parameter (#2580)
c18400a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ichard26 @JelleZijlstra