Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

black-primer: Print summary after individual failures #2570

Merged
merged 1 commit into from Oct 28, 2021
Merged

black-primer: Print summary after individual failures #2570

merged 1 commit into from Oct 28, 2021

Conversation

nipunn1313
Copy link
Contributor

If the individual failures are verbose, it's useful to have
the summary at the end. Otherwise, it can be really difficult
to figure out which projects have an issue.

Checklist - did you ...

  • Add a CHANGELOG entry if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation? (not necessary)

JelleZijlstra
JelleZijlstra reviewed Oct 28, 2021
View reviewed changes
CHANGES.md Outdated Show resolved Hide resolved
@nipunn1313
black-primer: Print summary after individual failures
c5a348a 
If the individual failures are verbose, it's useful to have
the summary at the end. Otherwise, it can be really difficult
to figure out which projects have an issue.
JelleZijlstra
JelleZijlstra approved these changes Oct 28, 2021
View reviewed changes
Copy link
Collaborator

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Will leave this for @cooperlees to also comment.

cooperlees
cooperlees approved these changes Oct 28, 2021
View reviewed changes
Copy link
Collaborator

@cooperlees cooperlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. This only helps and regresses nothing. I just used grep and found it easy to workout things.

@cooperlees cooperlees merged commit 5434407 into psf:main Oct 28, 2021
JelleZijlstra pushed a commit that referenced this pull request Nov 16, 2021
@nipunn1313 @JelleZijlstra
black-primer: Print summary after individual failures (#2570)
74e07e5 
If the individual failures are verbose, it's useful to have
the summary at the end. Otherwise, it can be really difficult
to figure out which projects have an issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@cooperlees cooperlees cooperlees approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nipunn1313 @JelleZijlstra @cooperlees