Fix missing toml extra

[ssbarnea]

Project packaging is using toml due to pyproject.toml but fails to mention it, causing installation failures with newer setuptools-scm 6.3.0

Fixes: #2449
Related: pypa/setuptools_scm#625

[ichard26]

Sigh, this past week has been terrible for our dependencies, hopefully this is the last mini-fire out of the bunch. Thank you for noticing and fixing! I'll try to push out a hotfix release later today containing both this fix and the other one for the OS native binaries.

[JelleZijlstra]

Sounds like setuptools-scm made a new release (6.3.1) that makes this change unnecessary.

[ssbarnea]

@JelleZijlstra While setuptools-scm made an emergency patch, I think that patch is needed. It only works because they happen to install toml themselves but that could change in the future.

@RonnyPfannschmidt WDYT about that, should we still fix it like that?

[RonnyPfannschmidt]

If you constraint greater than 6.3.0 and setuptools greater than 45 you can skip the extra,

[ichard26]

I'm going to play it safe and just keep the extra (although in addition to bumping both setuptools and setuptools-scm's minimum requirements to hopefully avoid significantly more broken build environments). I want to do a hotfix release today, and this should be good enough for now. We can always iterate later.

[sveitser]

Would be possible to make the release that includes this change? It would allow us to avoid patching black (NixOS/nixpkgs#137617) in nixpkgs after updating setuptools_scm to 6.3.1.

[ichard26]

@sveitser Sorry, I was planning to do a release but I simply just didn't have enough free time to be comfortable being the release manager. I've messaged the team asking if someone can pick it up but I can't promise anything as it's now out of my control :/

[ichard26]

@sveitser status update, Jelle has just finished the first half of the release process and now 21.9b0 should be up and working on PyPI.

[sveitser]

That was fast. Thank you!