Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pre-commit example shouldn't encourage deprecated practice #2415

Closed
MarcoGorelli opened this issue Aug 7, 2021 · 2 comments
Closed

pre-commit example shouldn't encourage deprecated practice #2415

MarcoGorelli opened this issue Aug 7, 2021 · 2 comments
Labels
T: documentation Improvements to the docs (e.g. new topic, correction, etc)

Comments

@MarcoGorelli
Copy link
Contributor

From the pre-commit docs

Using a branch name (or HEAD) for the value of rev is not supported and will only represent the state of that mutable ref at the time of hook installation (and will NOT update automatically).

I'd suggest that the docs just use the latest tag in their example
@MarcoGorelli MarcoGorelli added the T: documentation Improvements to the docs (e.g. new topic, correction, etc) label Aug 7, 2021
@MarcoGorelli MarcoGorelli mentioned this issue Aug 7, 2021
Merged
@asottile
Copy link
Contributor

#420 is a duplicate

@MarcoGorelli
Copy link
Contributor Author

MarcoGorelli commented Aug 10, 2021 •
edited

indeed - thanks, I'll change the PR (#2416) to reference that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T: documentation Improvements to the docs (e.g. new topic, correction, etc)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asottile @MarcoGorelli