Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Docker tag 'latest_release' #2374

Merged
merged 1 commit into from Jul 16, 2021
Merged

Create Docker tag 'latest_release' #2374

merged 1 commit into from Jul 16, 2021

Conversation

pszlazak
Copy link
Contributor

Docker images created during release process will have extra tag 'latest_release'.

This closes #2373.

With this change image with following tags was created when release was created:

docker-release-images

Steps in workflow:

docker-release-steps

And image with following tags was created for regular commit (you can still see previously created tags 99.9b0 and latest_release for image with digest ids f9846dab1900 for linux/amd64 and 7e76799a752c for linux/arm64):

docker-regular-commit-images

Steps in workflow:

docker-regular-commit-steps

@pszlazak
Create Docker tag 'latest_release'
4f0c45f 
Docker images created during release process will have extra tag 'latest_release'.

This closes psf#2373.
@pszlazak pszlazak mentioned this pull request Jul 16, 2021
Closed
cooperlees
cooperlees approved these changes Jul 16, 2021
View reviewed changes
Copy link
Collaborator

@cooperlees cooperlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - For bonus points or I can do later - We should describe the tags and their intended usages somewhere in our documentation.

If you have time that would be awesome, otherwise I'll add one day.

.github/workflows/docker.yml
@@ -40,5 +40,14 @@ jobs:
push: true
tags: pyfound/black:latest,pyfound/black:${{ env.GIT_TAG }}

- name: Build and push latest_release tag
if: ${{ github.event_name == 'release' && github.event.action == 'created' }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks for testing + finding these if conditions!

@cooperlees
Copy link
Collaborator

  • Also, let's add a CHANGES.md entry about this since it might be useful for a lot of people / docker users.

@cooperlees cooperlees merged commit 4622e4c into psf:main Jul 16, 2021
@pszlazak pszlazak mentioned this pull request Aug 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cooperlees cooperlees cooperlees approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docker release - tags used for created images
2 participants
@pszlazak @cooperlees