New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker release - tags used for created images #2373
Comments
Hi, Thanks for the report, but that is not how docker hub works by default and how most projects seem to use default latest tagging with their docker images too. We don’t control the So our tagging today is:
I guess we could introduce a tag (maybe |
Just confirmed using open source Docker Registry:
So I can be in the situation where I have:
Then I can retag them, so I guess the problem is with following line of
Maybe you should have two separate steps:
Please check following documentation:
Although I have no place to check if it works. |
I am all for doing this, but I don't like using For testing this: You can fork black and push to your own |
Docker images created during release process will have extra tag 'latest_release'. This closes psf#2373.
OK, tested. Pull request is created -> #2374. |
Docker images created during release process will have extra tag 'latest_release'. This closes #2373.
Describe the bug
When you are creating Docker image, you always tag it with
latest
tag and either:or:
latest_non_release
This is done in line # 41 of docker.yml.
Earlier
GIT_TAG
is prepared in line # 32 of docker.yml.To Reproduce
Pull both images:
Check version of Black for both images:
Of course, there can be a point in time when
latest
is same as image tagged with Git tag, but every push tomain
branch will produce new Docker image.Expected behavior
latest
tag should correspond to latest released version of Black. So in my automation I can always pull Docker image related to the newest released version of Black.Environment (please complete the following information):
N/A
Does this bug also happen on main?
N/A
Additional context
N/A
The text was updated successfully, but these errors were encountered: