Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept empty stdin (close #2337) #2346

Merged
merged 6 commits into from Jun 23, 2021
Merged

Accept empty stdin (close #2337) #2346

merged 6 commits into from Jun 23, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jun 22, 2021

fix #2337: Now Black does not fail for empty stdin file 馃憤

Copy link
Collaborator

@felix-hilden felix-hilden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch! The change itself looks good, and the command line result is completely fine without the newline. I left a small nitpick below, but feel free to ignore it!

tests/test_black.py Outdated Show resolved Hide resolved
@felix-hilden
Copy link
Collaborator

Could you also write a change log entry? I think this is worth notifying users.

@felix-hilden
Copy link
Collaborator

Thanks for the fast turnaround, LGTM!

tests/test_black.py Outdated Show resolved Hide resolved
tests/test_black.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@ichard26 ichard26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot for the quick patch, it's well appreciated 馃枻

@ichard26 ichard26 merged commit 017aafe into psf:main Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zero length stdin input causes black to fail (regression)
3 participants