Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add STDIN test to primer #2315

Merged
merged 4 commits into from Jun 11, 2021
Merged

Add STDIN test to primer #2315

merged 4 commits into from Jun 11, 2021

Conversation

cooperlees
Copy link
Collaborator

  • Check that out STDIN black support stays working
  • Add asyncio.subprocess STDIN pip via communicate
  • We just check we format python code from primer's lib.py

Fixes #2310

@cooperlees cooperlees added C: integrations Editor plugins and other integrations C: configuration CLI and configuration labels Jun 8, 2021
- Check that out STDIN black support stays working
- Add asyncio.subprocess STDIN pip via communicate
- We just check we format python code from primer's `lib.py`

Fixes #2310
@cooperlees
Copy link
Collaborator Author

I think we need to revise the .md only file push causing no unit tests running ...

@cooperlees cooperlees requested a review from ichard26 June 8, 2021 04:29
@JelleZijlstra
Copy link
Collaborator

Why do we need to test this with primer specifically? There are already various unit tests for stdin in test_black.py.

@cooperlees
Copy link
Collaborator Author

cooperlees commented Jun 8, 2021

This ensures we don’t break the ‘-‘ cli and the whole pipeline from stdin to return value using this read from STDIN option. I've seen Unit tests miss things before and this was simple to add and fast to execute so I see no downside to this.

It also keeps our integrations tests testing as much as we can. Next I’d like to get some different CLI usages too.

@cooperlees cooperlees merged commit aa31a11 into main Jun 11, 2021
@cooperlees cooperlees deleted the primer_check_stdin branch June 11, 2021 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: configuration CLI and configuration C: integrations Editor plugins and other integrations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add STDIN primer test
2 participants