Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't uvloop.install on import #2303

Merged
merged 2 commits into from Jun 3, 2021
Merged

don't uvloop.install on import #2303

merged 2 commits into from Jun 3, 2021

Conversation

JelleZijlstra
Copy link
Collaborator

Fixes #2302

skrawcz
skrawcz approved these changes Jun 3, 2021
View reviewed changes
Copy link

@skrawcz skrawcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick turn around. Looks good!

@ambv ambv merged commit df1c86c into main Jun 3, 2021
@ambv ambv deleted the uvloop branch June 3, 2021 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skrawcz skrawcz skrawcz approved these changes

@cooperlees cooperlees Awaiting requested review from cooperlees

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Black as a library import should check for running event loop before installing
3 participants
@JelleZijlstra @skrawcz @ambv