Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest Python in uploading binaries #2260

Merged
merged 3 commits into from May 27, 2021

Conversation

felix-hilden
Copy link
Collaborator

@felix-hilden felix-hilden commented May 26, 2021

From #2252, here to claim my bonus points: I found a way to always use the latest Python minor in GitHub Actions. It seemed easy enough to just drop in, although I'm not really sure how it could be verified without actually uploading.

I do trust the documentation, but if you're a bit scared (like I am too), we could just have the version be set to 3.9 for a guaranteed success. What do ya reckon?


skip news? I'm still not really sure what changes should end up in the changelog but I'm slowly getting there 😅

Copy link
Collaborator

@cooperlees cooperlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel no pinning at all is needed here. I also feel this minor version pinning won’t do much as there is no idea when a 4.0 will happen …

Let’s see what other maintainers say here.

.github/workflows/upload_binary.yml Show resolved Hide resolved
.github/workflows/upload_binary.yml Outdated Show resolved Hide resolved
@felix-hilden
Copy link
Collaborator Author

For some reason I prefer * to x when it's the only one there. I think it's a more familiar wildcard. I also added a changelog entry because I felt like it. Maybe it's better to err on the side of informing users more 😄

Good to go?

@ichard26 ichard26 added the C: maintenance Related to project maintenance, e.g. CI, testing, policy changes, releases label May 27, 2021
uses: actions/setup-python@v2
with:
python-version: ${{ matrix.python-version }}
python-version: "*"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I leave this line out in other CI jobs but I guess this is more explicit wildcard …

@cooperlees cooperlees merged commit d3670d9 into psf:main May 27, 2021
@ichard26 ichard26 linked an issue May 28, 2021 that may be closed by this pull request
@felix-hilden felix-hilden deleted the binary-latest-python branch June 1, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: maintenance Related to project maintenance, e.g. CI, testing, policy changes, releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Binary building CI to latest python (3.9)
4 participants