New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use latest Python in uploading binaries #2260
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel no pinning at all is needed here. I also feel this minor version pinning won’t do much as there is no idea when a 4.0 will happen …
Let’s see what other maintainers say here.
For some reason I prefer Good to go? |
uses: actions/setup-python@v2 | ||
with: | ||
python-version: ${{ matrix.python-version }} | ||
python-version: "*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I leave this line out in other CI jobs but I guess this is more explicit wildcard …
From #2252, here to claim my bonus points: I found a way to always use the latest Python minor in GitHub Actions. It seemed easy enough to just drop in, although I'm not really sure how it could be verified without actually uploading.
I do trust the documentation, but if you're a bit scared (like I am too), we could just have the version be set to 3.9 for a guaranteed success. What do ya reckon?
skip news
? I'm still not really sure what changes should end up in the changelog but I'm slowly getting there 😅