Add optional uvloop import #2258
Conversation
- If we find `uvloop` in the env for black, blackd or black-primer lets try and use it - Add a uvloop extra install Fixes #2257 Test: - Add ci job to install black[uvloop] and run a primer run with uvloop - Only with latest python (3.9) - Will be handy to compare runtimes as a very unoffical benchmark
|
Why are tests and lints skipped? Cause last commit only changed the |
|
Yep. I made that change because of all of the documentation changes lately which don't need the (relatively) expensive primer and test workflows. In hidesight this isn't great UX even if it's technically speaking totally fine safety wise. We can revert it by simply removing the |
|
|
||
| jobs: | ||
| build: | ||
| # We want to run on external PRs, but not on our own internal PRs as they'll be run |
There was a problem hiding this comment.
what does internal vs external mean in this context?
There was a problem hiding this comment.
This is copy pasta to maintain other CI behavior - this stops running the same CI twice for maintainers like me who make a branch and push to the black repo itself. @ichard26 did this and I like that it saves some resources. GitHub should really default to this to save CPU. One of us should go work there and claim the reward points.
uvloopin the env for black, blackd or black-primer lets try and use itFixes #2257
Test: