Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Binary building CI to latest python (3.9) #2252

Closed
cooperlees opened this issue May 24, 2021 · 2 comments · Fixed by #2260
Closed

Move Binary building CI to latest python (3.9) #2252

cooperlees opened this issue May 24, 2021 · 2 comments · Fixed by #2260
Labels
C: integrations Editor plugins and other integrations C: maintenance Related to project maintenance, e.g. CI, testing, policy changes, releases

Comments

@cooperlees
Copy link
Collaborator

cooperlees commented May 24, 2021 •
edited

Today we hard set python version to 3.7 for building our static binaries we push to GitHub. Lets move this to 3.9

https://github.com/psf/black/blob/main/.github/workflows/upload_binary.yml

  • Bonus Points: Just don't set the version and we automatically move as new version of Python come out.
@cooperlees cooperlees added the C: integrations Editor plugins and other integrations label May 24, 2021
@ichard26 ichard26 added the C: maintenance Related to project maintenance, e.g. CI, testing, policy changes, releases label May 24, 2021
@felix-hilden felix-hilden mentioned this issue May 26, 2021
Merged
@felix-hilden
Copy link
Collaborator

I think this can be closed now, my bad for not automating it in the PR itself.

@ichard26 ichard26 linked a pull request May 28, 2021 that will close this issue
Use latest Python in uploading binaries #2260
Merged
@ichard26
Copy link
Collaborator

And I totally forget to close this issue when I originally noticed this was still opened 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: integrations Editor plugins and other integrations C: maintenance Related to project maintenance, e.g. CI, testing, policy changes, releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use latest Python in uploading binaries felix-hilden/black
3 participants
@cooperlees @felix-hilden @ichard26