Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use codespell to find typos #2228

Merged
merged 1 commit into from May 13, 2021
Merged

Use codespell to find typos #2228

merged 1 commit into from May 13, 2021

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented May 13, 2021

Fix typos discovered by https://github.com/codespell-project/codespell

codespell --ignore-words-list="ans,hart,ot,poit,reallllly,tring" .

src/black/trans.py Outdated Show resolved Hide resolved
@@ -29,3 +29,9 @@ repos:
hooks:
- id: prettier
args: [--prose-wrap=always, --print-width=88]

- repo: https://github.com/codespell-project/codespell
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure adding this to pre-commit is worth it; it may just slow things down. Open to other opinions though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

% time codespell --ignore-words-list="ans,hart,ot,poit,reallllly,tring" .

0.24s user 0.02s system 91% cpu 0.284 total

Could also run it in a GitHub Action.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropped the pre-commit.

@JelleZijlstra JelleZijlstra merged commit 445f094 into psf:main May 13, 2021
@cclauss cclauss deleted the codespell branch May 13, 2021 18:01
@ichard26 ichard26 removed their request for review May 13, 2021 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants