Refactor src/black/__init__.py into many files
#2206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ichard26
added
C: cleanup
|
Chatting with Cooper via IRC, they want this refactor to publicized in the CHANGELOG. I don't feel strongly, but I'm putting the idea out there. I think their rational was that this may introduce bugs and crashes so warning users (explicitly or implying) is a good idea. |
I agree. This change will likely break users who |
|
Also, thanks @ambv for getting this done! This will make Black's code a lot easier to maintain and understand and I'm happy we're finally doing it! |
Feels like this would be easier for new contributors to understand where to look.
ichard26
reviewed
May 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's the same code but in smaller chunks.