Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into alternatives to using regex #2197

Closed
JelleZijlstra opened this issue May 4, 2021 · 1 comment · Fixed by #2663
Closed

Look into alternatives to using regex #2197

JelleZijlstra opened this issue May 4, 2021 · 1 comment · Fixed by #2663
Assignees
Labels
C: dependencies S: accepted The changes in this design / enhancement issue have been accepted and can be implemented T: enhancement New feature or request

Comments

@JelleZijlstra
Copy link
Collaborator

We're using the regex third-party library to avoid a bug around certain Unicode symbols: see #1047 (PR) and #455 (issue). However, this dependency is costly because it's a C library and compiling it is difficult for some users. We should explore rewriting the relevant parts of the parser to not use a regex so we can avoid this dependency.

@JelleZijlstra JelleZijlstra added the T: enhancement New feature or request label May 4, 2021
@ichard26 ichard26 added S: accepted The changes in this design / enhancement issue have been accepted and can be implemented blib2to3 C: dependencies labels May 4, 2021
@ichard26
Copy link
Collaborator

ichard26 commented Dec 1, 2021

And with the merger of #2654 and #2644 the last thing to do is to remove references to regex in the documentation and setup.py, Pipfile[.lock] 🎉

@ichard26 ichard26 linked a pull request Dec 2, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: dependencies S: accepted The changes in this design / enhancement issue have been accepted and can be implemented T: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants