Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

primer: Add --no-diff option #2187

Merged
merged 2 commits into from May 4, 2021
Merged

primer: Add --no-diff option #2187

merged 2 commits into from May 4, 2021

Conversation

cooperlees
Copy link
Collaborator

@cooperlees cooperlees commented May 3, 2021 •
edited

  • Allow runs with no code diff output
  • This is handy for reducing output to see which file is erroring

Test:

  • Edit config for 'channels' to expect no changes and run with --no-diff and see no diff output
  • Fix unittests to handle new argument

@cooperlees cooperlees added T: enhancement New feature or request C: integrations Editor plugins and other integrations C: configuration CLI and configuration labels May 3, 2021
@cooperlees
primer: Add --no-diff option
a765c70 
- Allow runs with no code diff output
- This is handy for reducing output to see which file is erroring

Test:
- Edit config for 'channels' to expect no changes and run with `--no-diff` and see no diff output
@cooperlees
Fix tests - supply default arg for no_diff on run_black + pass bool t…
6a3effd 
…o async_main
@ambv ambv merged commit a18c7bc into master May 4, 2021
@JelleZijlstra JelleZijlstra deleted the primer_diff_optional branch May 4, 2021 13:24
@ichard26 ichard26 added the C: maintenance Related to project maintenance, e.g. CI, testing, policy changes, releases label May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C: configuration CLI and configuration C: integrations Editor plugins and other integrations C: maintenance Related to project maintenance, e.g. CI, testing, policy changes, releases T: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cooperlees @ambv @ichard26