Detect '@' dotted_name '(' ')' NEWLINE as a simple decorator
#2182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ichard26
force-pushed
the
fix-relaxed-decorator-detection
branch
from
dc6404b
to
c2a6c26
Compare
Previously the RELAXED_DECORATOR detection would be falsely True on that example. The problem was that an argument-less parentheses pair didn't pass the `is_simple_decorator_trailer` check even it should. OTOH a parentheses pair containing an argument or more passed as expected.
ichard26
force-pushed
the
fix-relaxed-decorator-detection
branch
from
c2a6c26
to
776aa2f
Compare
|
Cancelled the 3.9 fuzz workflow cause it was getting stuck on Setup Python and then also seemed to exhibit the same behavior that leads to it taking forever and then failing. All of the other runs are passing just fine anyway... |
JelleZijlstra
approved these changes
May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the RELAXED_DECORATOR detection would be falsely True on that
example. The problem was that an argument-less parentheses pair didn't
pass the
is_simple_decorator_trailercheck even it should. OTOH aparentheses pair containing an argument or more passed as expected.
Fixes #2181
I whipped up this fix really quickly so apologies if this fix is garbage :)