Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure to format complex assert statement #2123

Closed
jmfrees opened this issue Apr 21, 2021 · 1 comment
Closed

Failure to format complex assert statement #2123

jmfrees opened this issue Apr 21, 2021 · 1 comment
Labels
C: unstable formatting Formatting changed on the second pass R: duplicate This issue or pull request already exists T: bug Something isn't working

Comments

@jmfrees
Copy link

jmfrees commented Apr 21, 2021

Describe the bug A clear and concise description of what the bug is.

Black fails to format complex assert statement.

To Reproduce Steps to reproduce the behavior:

  1. Take a file black_bug.py with contents
import json

def problem_function():
    assert foo(
        json.dumps(some_decently_long_variable_name), long_dict_name["baz"], last_variable
    ) == (False, True, [other_dict["somekey"]])
  1. Run Black on it with no args, black black_bug.py
  2. See error
error: cannot format black_bug.py: INTERNAL ERROR: Black produced different code on the second pass of the formatter.  Please report a bug on https://github.com/psf/black/issues.  This diff might be helpful: /tmp/blk_cjwvmatg.log
Oh no! 💥 💔 💥
1 file failed to reformat.

Expected behavior A clear and concise description of what you expected to happen.

Format file without error

Environment (please complete the following information):

  • Version: 20.8b1
  • OS and Python version: Arch Linux x86_64/Python 3.9.3

Does this bug also happen on master? To answer this, you have two options:
Yes, this occurs on master as seen here.

Additional context Add any other context about the problem here.

If you shorten anything on the line of the arguments for foo (line 5 in the code block above) by one or two characters, black formats correctly.

@jmfrees jmfrees added the T: bug Something isn't working label Apr 21, 2021
@ichard26 ichard26 added C: unstable formatting Formatting changed on the second pass R: duplicate This issue or pull request already exists labels Apr 21, 2021
@ichard26
Copy link
Collaborator

Hello!

All reproduction cases in this issue format without error on master. The fixing commit was 8672af3 from PR GH-2126. I'll be marking this issue as a duplicate of GH-1629 since that's what GH-2126 aimed to fix and it's highly likely this issue falls under GH-1629.

Since we use the issue tracker as a reflection of what's on master, I'll be closing this issue. If you have any issues, especially with the new (but stable) output, please open a new issue. Oh and the fix should be available in a published release soon, see GH-2125 for more info.

Thank you for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: unstable formatting Formatting changed on the second pass R: duplicate This issue or pull request already exists T: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants