Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numeric literal formatting is inconsistent with Black code style document #2066

Closed
Jackenmen opened this issue Mar 26, 2021 · 1 comment
Closed
Labels
T: documentation Improvements to the docs (e.g. new topic, correction, etc)

Comments

@Jackenmen
Copy link
Contributor

According to Numeric literals section of Black code style, the numeric literals should use lowercase letters for the syntactic parts and uppercase letters for the digits themselves but this seems to no longer be the case on master (has been changed in #1775). I don't really agree with that change but nonetheless, the implementation should be consistent with the documentation so it looks like one of these needs changing.

I used a blank issue as this very well may just be a documentation issue.

@JelleZijlstra
Copy link
Collaborator

The current documentation in https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html#numeric-literals is consistent with Black's actual behavior. (We changed back to uppercase for hex digits.)

@JelleZijlstra JelleZijlstra added the T: documentation Improvements to the docs (e.g. new topic, correction, etc) label May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: documentation Improvements to the docs (e.g. new topic, correction, etc)
Projects
None yet
Development

No branches or pull requests

2 participants