Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Black produced different code on the second pass of the formatter #1993

Closed
Debakel opened this issue Feb 18, 2021 · 2 comments
Closed

Black produced different code on the second pass of the formatter #1993

Debakel opened this issue Feb 18, 2021 · 2 comments
Labels
C: unstable formatting Formatting changed on the second pass R: duplicate This issue or pull request already exists T: bug Something isn't working

Comments

@Debakel
Copy link

Debakel commented Feb 18, 2021

Describe the bug: When formatting this file an error occurs:

error: cannot format test_compliance_check/test_fetch_target_rights.py: INTERNAL ERROR: Black produced different code on the second pass of the formatter.  Please report a bug on https://github.com/psf/black/issues.  This diff might be helpful: /var/folders/jd/wpwhg6ls5cbc_007sjkzn08h0000gn/T/blk_gmoo7yei.log

To Reproduce Steps to reproduce the behavior:

  1. Take this file
  2. Run Black on it
  3. Error; See above

Expected behavior
Black should successfully format the file.

Environment (please complete the following information):

  • Version: master

Does this bug also happen on master? Yes.

@Debakel Debakel added the T: bug Something isn't working label Feb 18, 2021
@ichard26 ichard26 added the C: unstable formatting Formatting changed on the second pass label Feb 19, 2021
@mvolfik
Copy link

mvolfik commented Feb 22, 2021

Likely a duplicate of #1629 , as this file works after applying #1958

@ichard26 ichard26 added the R: duplicate This issue or pull request already exists label Apr 25, 2021
@ichard26
Copy link
Collaborator

Hello!

All reproduction cases in this issue format without error on master. The fixing commit was 8672af3 from PR GH-2126. I'll be marking this issue as a duplicate of GH-1629 since that's what GH-2126 aimed to fix and it's highly likely this issue falls under GH-1629.

Since we use the issue tracker as a reflection of what's on master, I'll be closing this issue. If you have any issues, especially with the new (but stable) output, please open a new issue. Oh and the fix should be available in a published release soon, see GH-2125 for more info.

Thank you for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: unstable formatting Formatting changed on the second pass R: duplicate This issue or pull request already exists T: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants