Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Black crashes when trying to format this example #1889

Closed
lsorber opened this issue Dec 28, 2020 · 2 comments
Closed

Black crashes when trying to format this example #1889

lsorber opened this issue Dec 28, 2020 · 2 comments
Labels
C: unstable formatting Formatting changed on the second pass R: duplicate This issue or pull request already exists T: bug Something isn't working

Comments

@lsorber
Copy link

lsorber commented Dec 28, 2020

Black crashes when trying to format this example:

φ = np.exp(
    1j * (X @ self.Z_ if self.shift_ is None else X @ self.Z_ - self.shift_),
    dtype=np.complex64 if X.dtype == np.float32 else None
) / np.sqrt(self.num_features)

Diff from black.now.sh:

INTERNAL ERROR: Black produced different code on the second pass of the formatter.  Please report a bug on https://github.com/psf/black/issues.  This diff might be helpful: /tmp/blk_dckjw0xt.log

Mode(target_versions=set(), line_length=88, string_normalization=True, experimental_string_processing=False, is_pyi=False)
--- source
+++ first pass
@@ -1,4 +1,4 @@
 φ = np.exp(
     1j * (X @ self.Z_ if self.shift_ is None else X @ self.Z_ - self.shift_),
-    dtype=np.complex64 if X.dtype == np.float32 else None
+    dtype=np.complex64 if X.dtype == np.float32 else None,
 ) / np.sqrt(self.num_features)
--- first pass
+++ second pass
@@ -1,4 +1,7 @@
-φ = np.exp(
-    1j * (X @ self.Z_ if self.shift_ is None else X @ self.Z_ - self.shift_),
-    dtype=np.complex64 if X.dtype == np.float32 else None,
-) / np.sqrt(self.num_features)
+φ = (
+    np.exp(
+        1j * (X @ self.Z_ if self.shift_ is None else X @ self.Z_ - self.shift_),
+        dtype=np.complex64 if X.dtype == np.float32 else None,
+    )
+    / np.sqrt(self.num_features)
+)
@lsorber lsorber added the T: bug Something isn't working label Dec 28, 2020
@ichard26 ichard26 added the C: unstable formatting Formatting changed on the second pass label Dec 28, 2020
@mvolfik
Copy link

mvolfik commented Feb 22, 2021

Works with #1958, so likely a duplicate of #1629

@ichard26 ichard26 added the R: duplicate This issue or pull request already exists label Apr 25, 2021
@ichard26
Copy link
Collaborator

ichard26 commented Apr 25, 2021

Hello!

All reproduction cases in this issue format without error on master. The fixing commit was 8672af3 from PR GH-2126. I'll be marking this issue as a duplicate of GH-1629 since that's what GH-2126 aimed to fix and it's highly likely this issue falls under GH-1629.

Since we use the issue tracker as a reflection of what's on master, I'll be closing this issue. If you have any issues, especially with the new (but stable) output, please open a new issue. Oh and the fix should be available in a published release soon, see GH-2125 for more info.

Thank you for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: unstable formatting Formatting changed on the second pass R: duplicate This issue or pull request already exists T: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants