Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTERNAL ERROR: Black produced different code on the second pass of the formatter #1862

Closed
jugmac00 opened this issue Dec 9, 2020 · 2 comments
Labels
C: unstable formatting Formatting changed on the second pass R: duplicate This issue or pull request already exists T: bug Something isn't working

Comments

@jugmac00
Copy link

jugmac00 commented Dec 9, 2020

Describe the bug A clear and concise description of what the bug is.
Formatting failed with following error:

INTERNAL ERROR: Black produced different code on the second pass of the formatter

To Reproduce Steps to reproduce the behavior:
use code like this:

class CompanyLocation:
    @security.private
    def longPrintString(self):
        """ return long printstring """
        return "%s  [%d Licences/%d active), %d active maintenance contracts, %d employees]" % (
            self.addressSingleLine(),
            len(self.licences()),
            len(self.activeLicences()),
            len(self.activeMaintenanceContracts()),
            len(self.employees())
        )

run black with no arguments (except above file)

Expected behavior A clear and concise description of what you expected to happen.
it should work

Environment (please complete the following information):

  • Version: 20.8b1
  • OS and Python version: Ubuntu 18.04, Python 3.7.9

Does this bug also happen on master? To answer this, you have two options:
Yes - problem still exists on master, ie in the web version.

Additional context Add any other context about the problem here.

diff provided by black for debugging purposes

Mode(target_versions=set(), line_length=88, string_normalization=True, experimental_string_processing=False, is_pyi=False)
--- source
+++ first pass
@@ -1158,16 +1158,19 @@
         )
 
     @security.private
     def longPrintString(self):
         """ return long printstring """
-        return "%s  [%d Licences/%d active), %d active maintenance contracts, %d employees]" % (
-            self.addressSingleLine(),
-            len(self.licences()),
-            len(self.activeLicences()),
-            len(self.activeMaintenanceContracts()),
-            len(self.employees())
+        return (
+            "%s  [%d Licences/%d active), %d active maintenance contracts, %d employees]"
+            % (
+                self.addressSingleLine(),
+                len(self.licences()),
+                len(self.activeLicences()),
+                len(self.activeMaintenanceContracts()),
+                len(self.employees()),
+            )
         )
 
     @security.private
     def mainAddress(self):
         """ return main address """
--- first pass
+++ second pass
@@ -1158,19 +1158,16 @@
         )
 
     @security.private
     def longPrintString(self):
         """ return long printstring """
-        return (
-            "%s  [%d Licences/%d active), %d active maintenance contracts, %d employees]"
-            % (
-                self.addressSingleLine(),
-                len(self.licences()),
-                len(self.activeLicences()),
-                len(self.activeMaintenanceContracts()),
-                len(self.employees()),
-            )
+        return "%s  [%d Licences/%d active), %d active maintenance contracts, %d employees]" % (
+            self.addressSingleLine(),
+            len(self.licences()),
+            len(self.activeLicences()),
+            len(self.activeMaintenanceContracts()),
+            len(self.employees()),
         )
 
     @security.private
     def mainAddress(self):
         """ return main address """
@jugmac00 jugmac00 added the T: bug Something isn't working label Dec 9, 2020
@hellocoldworld
Copy link

hellocoldworld commented Dec 9, 2020

same issue here, I think it's being tracked in #1629

@ichard26 ichard26 added the C: unstable formatting Formatting changed on the second pass label Dec 12, 2020
@ichard26 ichard26 added the R: duplicate This issue or pull request already exists label Apr 25, 2021
@ichard26
Copy link
Collaborator

Hello!

All reproduction cases in this issue format without error on master. The fixing commit was 8672af3 from PR GH-2126. I'll be marking this issue as a duplicate of GH-1629 since that's what GH-2126 aimed to fix and it's highly likely this issue falls under GH-1629.

Since we use the issue tracker as a reflection of what's on master, I'll be closing this issue. If you have any issues, especially with the new (but stable) output, please open a new issue. Oh and the fix should be available in a published release soon, see GH-2125 for more info.

Thank you for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: unstable formatting Formatting changed on the second pass R: duplicate This issue or pull request already exists T: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants