Allow same RHS expressions in annotated assignments as in regular assignments #1835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ichard26
force-pushed
the
allow_same_rhs_expressions
branch
from
7aa643e
to
2cc26f5
Compare
zsol
approved these changes
Nov 22, 2020
tests/data/python38.py
Outdated
| # all right hand side expressions allowed in regular assignments are now also allowed in | ||
| # annotated assignments | ||
| a : Tuple[ str, int] = "1", 2 | ||
| a: List [ str] = *x |
There was a problem hiding this comment.
Looks like technically this is a syntax error, but it's allowed in the cpython grammar. Black should probably not be used to validate syntax though, so it's probably fine :)
There was a problem hiding this comment.
Yeah, it's probably fine. As long we don't add parenthesizes to any of the above, the case of the following won't happen :)
- invalid python
- Black accepts it
- Black generates valid python at the end
hauntsaninja
approved these changes
Nov 23, 2020
There was a problem hiding this comment.
This looks right to me too, it's the same change CPython made in https://bugs.python.org/issue35814 / matches what's in the last version of the non PEG parser.
ichard26
force-pushed
the
allow_same_rhs_expressions
branch
from
2cc26f5
to
c195d3e
Compare
|
Thanks @hauntsaninja for reviewing; yep I intended this to be a backport of python/cpython@8565f6b and python/cpython@62c35a8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1828.
Fixes #1189.
@zsol I would appreciate if you could review as this is my first time swimming in these waters, and therefore I have no idea what I am doing :D. Thanks in advance!