Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformatting print()s that span multiple lines does not remove extraneous "s #170

Closed
cricalix opened this issue Apr 25, 2018 · 2 comments
Closed

Comments

@cricalix
Copy link

cricalix commented Apr 25, 2018

Operating system: Linux
Python version: 3.6.3rc1
Black version: 18.4a1
Does also happen on master: Yes (18.4a3 cloned today)

Original code:

            self.logger.debug(
                f'Skipped {skipped_count} virtual '
                f'interfaces for {device.name}'
            )

black'd code:

            self.logger.debug(
                f"Skipped {skipped_count} virtual " f"interfaces for {device.name}"
            )

Could black detect that it's done this (with or without f-string markers), and remove the ' " " ' that results, or is that considered too invasive a change to the code?

@Lukas0907
Copy link

See also #26, possible duplicate.

@cricalix
Copy link
Author

Absolutely a duplicate :( Didn't see that in my searching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants