Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concatenation of a string is not correct. #1277

Closed
petervanderdoes opened this issue Feb 18, 2020 · 1 comment
Closed

Concatenation of a string is not correct. #1277

petervanderdoes opened this issue Feb 18, 2020 · 1 comment
Labels
T: bug Something isn't working

Comments

@petervanderdoes
Copy link

petervanderdoes commented Feb 18, 2020

Concatenation of a string is not correct.

Steps to reproduce the behavior:

  1. Original line:

     self.enqueue_script(handle='bootstrap',
                         path='xxxxxxxxxxxx/js/vendor/bootstrap.bundle'
                              '.min.js',
                         in_footer=True)
    
  2. Run Black no arguments

  3. Result:

     self.enqueue_script(
         handle="bootstrap",
         path="xxxxxxxxxxxx/js/vendor/bootstrap.bundle" ".min.js",
         in_footer=True,
     )
    

Expected behavior
self.enqueue_script(
handle="bootstrap",
path="esperanzahomes/js/vendor/bootstrap.bundle.min.js",
in_footer=True,
)

Not having a space in the path string.

Environment (please complete the following information):

  • Version: black, version 19.10b0
  • OS and Python version: Mac OS Catalina. Black installed through brew. Python 2.7.17

Does this bug also happen on master? Yes, using the online formatter.

@petervanderdoes petervanderdoes added the T: bug Something isn't working label Feb 18, 2020
@hugovk
Copy link
Contributor

hugovk commented Feb 18, 2020

Duplicate of #26.

https://pypi.org/project/flake8_implicit_str_concat/ is a handy tool to detect these so you can manually fix them.

@zsol zsol closed this as completed Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants