Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Argument::that allows params #73

Merged
merged 2 commits into from May 24, 2020
Merged

fix: Argument::that allows params #73

merged 2 commits into from May 24, 2020

Conversation

mr-feek
Copy link
Contributor

@mr-feek mr-feek commented May 24, 2020

fixes #72

@weirdan
Copy link
Member

weirdan commented May 24, 2020

Mind adding a test for this?

@weirdan
Copy link
Member

weirdan commented May 24, 2020

Also you may want to rebase - I've just fixed tests in master

@mr-feek
Copy link
Contributor Author

mr-feek commented May 24, 2020

sure, comin right up

@mr-feek
Copy link
Contributor Author

mr-feek commented May 24, 2020

how's that lookin @weirdan ? I figured Prophecy was worthy of its own test case, since it's relatively independent of phpunit

@weirdan
Copy link
Member

weirdan commented May 24, 2020

Looking good!

@weirdan weirdan merged commit 138998f into psalm:master May 24, 2020
@weirdan
Copy link
Member

weirdan commented May 24, 2020

Released in 0.10.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Prophecy][False Positive] Argument::that problems
2 participants
@mr-feek @weirdan