Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception class in InvocationMocker und MockBuilder strub #109

Merged
merged 1 commit into from
May 29, 2021

Conversation

weph
Copy link
Contributor

@weph weph commented May 29, 2021

After enabling checkForThrowsDocblock psalm crashed with

Uncaught Exception: Could not get class storage for phpunit\framework\mockobject\builder\runtimeexception

I had a look at PHPUnit and there really isn't a RuntimeException in that namespaces and after browsing through some versions I think there never has been. So I guess what's really meant is the global one.

@weirdan
Copy link
Member

weirdan commented May 29, 2021

I fixed test failures on master, mind rebasing this? I can't push to your repo, either because you did not enable 'Updates from maintainers' checkbox or because the PR was created from weph:master and not from a dedicated branch.

@weph
Copy link
Contributor Author

weph commented May 29, 2021

I checked "Allow edits by maintainers" and according to the help text you should be allowed to push to my master 🤷🏻‍♂️
But anyway... I just rebased it

@weirdan weirdan merged commit 31d15bb into psalm:master May 29, 2021
@weirdan
Copy link
Member

weirdan commented May 29, 2021

Thanks!

@weirdan
Copy link
Member

weirdan commented May 29, 2021

Released in 0.15.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants