Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SuppressHandler doesn't work with 2 levels inheritance #340

Open
palviggi-videoslots opened this issue Apr 5, 2023 · 0 comments
Open

SuppressHandler doesn't work with 2 levels inheritance #340

palviggi-videoslots opened this issue Apr 5, 2023 · 0 comments

Comments

@palviggi-videoslots
Copy link

palviggi-videoslots commented Apr 5, 2023

I had a lot of Commands with common functionality. I moved the common features into an abstract class and made all my commands extend from it. Now I have lots of messages in the psalm out put about PropertyNotSetInConstructor [...]$laravel as well as $name, $input and $output.

Those are normally suppressed by the BY_PARENT_CLASS rules, but there's an order of execution problem: AfterClassLikeVisit can be called before populate, at which point we only have 1 level of parent classes available to compare.

I guess one option could be to change it into AfterCodebasePopulatedInterface, and analyze all available classes at that point, not sure how much change it would be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant