Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename psalm.phar to psalm #1

Open
thePanz opened this issue Apr 25, 2019 · 3 comments
Open

Rename psalm.phar to psalm #1

thePanz opened this issue Apr 25, 2019 · 3 comments

Comments

@thePanz
Copy link

thePanz commented Apr 25, 2019

When using this package the executable phar is called vendor/bin/psalm.phar
This could lead to some confusion when the official guide is used, as it refers to vendor/bin/psalm as the command to run.
@bdsl
Copy link

bdsl commented Jun 6, 2019

@thePanz I hadn't seen your issue but I just made PR vimeo/psalm#1748 in the main repo to fix exactly this issue. It doesn't rename psalm.phar since there may now be build pipelines that require it to have that name, but it adds an executable PHP file called psalm which requires psalm.phar.

@thePanz
Copy link
Author

thePanz commented Jun 7, 2019 via email

@bdsl
Copy link

bdsl commented Jun 7, 2019 •
edited

@muglug has merged the PR, so this should be fixed in the next release.

@muglug muglug closed this as completed Jun 7, 2019
bdsl added a commit to bdsl/psalm that referenced this issue Jun 8, 2019
@bdsl
Delete broken scripts from phar distribution
87c5c4d 
This resolves vimeo#1758 but signals
that psalm/phar#1 was never really fixed.
@bdsl bdsl mentioned this issue Jun 8, 2019
Merged
muglug pushed a commit to vimeo/psalm that referenced this issue Jun 8, 2019
@bdsl @muglug
Delete broken scripts from phar distribution
08d029b 
This resolves #1758 but signals
that psalm/phar#1 was never really fixed.
@muglug muglug reopened this Jun 8, 2019
@bdsl bdsl mentioned this issue Jun 9, 2019
Closed
bdsl added a commit to bdsl/psalm that referenced this issue Dec 27, 2019
@bdsl
Remove references to deleted scripts in psalm/phar composer.json
d6713ff 
This should stop the error messages we are seeing on installing
psalm/phar:
    Skipped installation of bin psalm for package psalm/phar: file not
    found in package
    Skipped installation of bin psalter for package psalm/phar: file
    not found in package
    Skipped installation of bin psalm-language-server for
    package psalm/phar: file not found in package
    Skipped installation of bin psalm-plugin for package
    psalm/phar: file not found in package

They can be put back in future if/when
psalm/phar#1 is fixed
bdsl added a commit to bdsl/psalm that referenced this issue Dec 27, 2019
@bdsl
Remove references to deleted scripts in psalm/phar composer.json
5cada58 
This should stop the error messages we are seeing on installing
psalm/phar:
    Skipped installation of bin psalm for package psalm/phar: file not
    found in package
    Skipped installation of bin psalter for package psalm/phar: file
    not found in package
    Skipped installation of bin psalm-language-server for
    package psalm/phar: file not found in package
    Skipped installation of bin psalm-plugin for package
    psalm/phar: file not found in package

They can be put back in future if/when
psalm/phar#1 is fixed
@bdsl bdsl mentioned this issue Dec 27, 2019
Merged
muglug pushed a commit to vimeo/psalm that referenced this issue Dec 27, 2019
@bdsl @muglug
Remove references to deleted scripts in psalm/phar composer.json (#2514)
5e90453 
This should stop the error messages we are seeing on installing
psalm/phar:
    Skipped installation of bin psalm for package psalm/phar: file not
    found in package
    Skipped installation of bin psalter for package psalm/phar: file
    not found in package
    Skipped installation of bin psalm-language-server for
    package psalm/phar: file not found in package
    Skipped installation of bin psalm-plugin for package
    psalm/phar: file not found in package

They can be put back in future if/when
psalm/phar#1 is fixed
KEINOS added a commit to KEINOS/TPL-PHP-HelloWorld that referenced this issue Mar 15, 2020
@KEINOS
fix: psalm command to run. psalm -> psalm.phar
e17cde1 
vimeo/psalm -> ./vendor/bin/psalm
psalm/phar -> ./vendor/bin/psalm.phar

- REF: psalm/phar#1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bdsl @thePanz @muglug