Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Move duplicated Aggregator calculation logic into Logic Classes #183

Open
Maelstromeous opened this issue Oct 12, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request p3 Minor issues

Comments

@Maelstromeous
Copy link
Member

Like I've done for the Vehicle Destroy and Vehicle Character Death logics, move the calculation logic into a singlar class so we can easily re-use it across both Instance and Global Aggregates. Right now, we're duplicating the exact same logic across both, the only difference being their destination, the same documents are created, which is inefficent.

Additionally, should the logic need to be tweaked, we would have to do it to both, which is a maintainability issue.

@Maelstromeous Maelstromeous added enhancement New feature or request p3 Minor issues labels Oct 12, 2020
@Maelstromeous Maelstromeous self-assigned this Oct 12, 2020
@Maelstromeous Maelstromeous added this to To do in PS2Alerts v3.0 Beta via automation Oct 12, 2020
@Maelstromeous Maelstromeous added this to To do in Aggregator 3.0 GA via automation Oct 12, 2020
@Maelstromeous Maelstromeous changed the title Refactor: Move duplicated logic into Logic Classes Refactor: Move duplicated Aggregator calculation logic into Logic Classes Oct 12, 2020
@Maelstromeous Maelstromeous removed this from To do in Aggregator 3.0 GA Nov 22, 2020
@Maelstromeous Maelstromeous removed this from To do in PS2Alerts v3.0 Beta Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request p3 Minor issues
Projects
Status: Todo
Development

No branches or pull requests

1 participant