Fix breakage in output with colors disabled #2158
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Investigating
Pry::Helpers#strip_color
I've found out that\e[1A\e[0G
and the prompt was being removed from the text.When the string was big enough, it wouldn't cause any trouble, as the output would just 'overwrite' it. But for strings such as 'puts "Hello"', or "'hello'.upcase" it would break the output in unexpected ways.
On master:
would become:
With this fix:
After my fix a spec on
spec/pry_repl_spec.rb:127
started failing withRegexpError: premature end of char-class
. A simple "string".match("do\n break #note the tab here\nend\n\e[1B\e[0G=> nil") raises an error. I've fixed that escaping the[
on 31590eaIt wasn't failing before because those strings were being matched by RSpec's fuzzy matcher and not by the regex itself.
Fixes #2148