Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bundler_spec test #2140

Merged
merged 1 commit into from Nov 28, 2020
Merged

Fix bundler_spec test #2140

merged 1 commit into from Nov 28, 2020

Conversation

utkarsh2102
Copy link
Contributor

@utkarsh2102 utkarsh2102 commented Jun 16, 2020

Thanks for your awesome work on maintaining pry, @kyrylo! ❤️

However, whilst maintaining pry in Debian, I noticed that there was a test failure:

➜  pry git:(master) rspec spec/integration/bundler_spec.rb

Randomized with seed 32029
Traceback (most recent call last):
-e:5:in `<main>': uninitialized constant Bundler (NameError)
F

Failures:

  1) Bundler when Pry requires Gemfile, which doesn't specify Pry as a dependency loads auto-completion correctly
     Failure/Error: expect($CHILD_STATUS.exitstatus).to eq(42)
     
       expected: 42
            got: 1
     
       (compared using ==)
     # ./spec/integration/bundler_spec.rb:26:in `block (3 levels) in <top (required)>'

Finished in 0.54534 seconds (files took 0.58163 seconds to load)
1 example, 1 failure

Failed examples:

rspec ./spec/integration/bundler_spec.rb:10 # Bundler when Pry requires Gemfile, which doesn't specify Pry as a dependency loads auto-completion correctly

This PR fixes the same and also arranges those requires in alphabetical order 😄

Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>

Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
@kyrylo
Copy link
Member

kyrylo commented Nov 28, 2020

Thanks for the kind words 🤎 but I probably don't deserve them 😅

@kyrylo kyrylo merged commit 7fb884f into pry:master Nov 28, 2020
@utkarsh2102 utkarsh2102 deleted the fix-bundler_spec-test branch November 28, 2020 22:52
@utkarsh2102
Copy link
Contributor Author

Hi @kyrylo,

..but I probably don't deserve them

You defintiely do! Thanks for all your work! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants