Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve appearance of help command listing #2120

Merged
merged 2 commits into from Apr 12, 2020
Merged

Improve appearance of help command listing #2120

merged 2 commits into from Apr 12, 2020

Conversation

barrettkingram
Copy link
Contributor

This PR improves the appearance of some of the commands in the help listing.

Previously:

Editing
  /^\s*!\s*$/        Clear the input buffer.
Aliases
  (?-mix:whereami[!?]+) Alias for `whereami`

Now:

Editing
  !                  Clear the input buffer.
Aliases
  /whereami[!?]+/    Alias for `whereami`

@bingram-eab
Display Bang command as "!" instead of regex in help listing
0b3b71e
@bingram-eab
Improve help listing for regex aliases
a164846 
This commit improves the appearance of regex aliases in the help index
by storing the result of calling #inspect on the regex as the listing.

For example, consider the `whereami` alias `/whereami[!?]+/`.
Previously this would appear in the help index as
`(?-mix:whereami[!?]+)`. This commit fixes this so it appears as
`/whereami[!?]+/`.
@kyrylo kyrylo merged commit 7a4166f into pry:master Apr 12, 2020
@kyrylo
Copy link
Member

kyrylo commented Apr 12, 2020

Thanks!

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Apr 27, 2020
misc/ruby-pry: update to 0.13.1
f3e52e4 
Update ruby-pry to 0.13.1.


### [v0.13.1][v0.13.1] (April 12, 2020)

#### Bug fixes

* Fixed bug where on invalid input only the last syntax error is displayed
  (instead of all of them) ([#2117](pry/pry#2117))
* Fixed `Pry::Config` raising `NoMethodError` on undefined option instead of
  returning `nil` (usually invoked via `Pry.config.foo_option` calls)
  ([#2126](pry/pry#2126))
* Fixed `help` command not displaying regexp aliases properly
  ([#2120](pry/pry#2120))
* Fixed `pry-backtrace` not working ([#2122](pry/pry#2122))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@barrettkingram @kyrylo @bingram-eab