Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address reported RUSTSEC vulnerabilities. #144

Merged
merged 2 commits into from Apr 7, 2022
Merged

Address reported RUSTSEC vulnerabilities. #144

merged 2 commits into from Apr 7, 2022

Conversation

Swaagie
Copy link
Contributor

@Swaagie Swaagie commented Apr 6, 2022 •
edited

  • Ignore RUSTSEC-2020-0159 for now
  • Use limited set of features from Chrono to address RUSTSEC-2020-0071
  • Regenerate lockfile

fixes #142

@Swaagie Swaagie mentioned this pull request Apr 6, 2022
Closed
@Swaagie Swaagie requested a review from nullpo-head April 6, 2022 22:25
@PiotrSikora
Copy link
Contributor

Could we avoid the noise of regenerating the lockfile? You could manually remove time from there and re-run cargo-raze without any arguments.

@PiotrSikora PiotrSikora added this to the v0.2.0 milestone Apr 7, 2022
@PiotrSikora
Copy link
Contributor

Alternatively, we could pull this after #145 to avoid the unrelated updates in this PR.

@Swaagie
dist: use clock and std features of chrono
6614057 
Signed-off-by: Martijn Swaagman <martijn@swaagman.online>
@Swaagie
chore: cargo audit ignore RUSTSEC-2020-0159
3c04536 
Signed-off-by: Martijn Swaagman <martijn@swaagman.online>
@Swaagie
Copy link
Contributor Author

Swaagie commented Apr 7, 2022

Updated to removal of time only.

PiotrSikora
PiotrSikora approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PiotrSikora PiotrSikora changed the title Address reported RUSTSEC vuln Address reported RUSTSEC vulnerabilities. Apr 7, 2022
@PiotrSikora PiotrSikora merged commit 5119d63 into proxy-wasm:master Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PiotrSikora PiotrSikora PiotrSikora approved these changes

@nullpo-head nullpo-head Awaiting requested review from nullpo-head

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.

Address RUSTSEC-2020-0071 and RUSTSEC-2020-0159
2 participants
@Swaagie @PiotrSikora