Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #114 not firing false positive on mark-callable-contracts for structs #115

Merged
merged 5 commits into from May 14, 2019
Merged

Fixes #114 not firing false positive on mark-callable-contracts for structs #115

merged 5 commits into from May 14, 2019

Conversation

habdelra
Copy link
Contributor

Fixes #114

@coveralls
Copy link

coveralls commented May 11, 2019 •
edited

Coverage Status

Coverage increased (+0.02%) to 97.582% when pulling ccdda9b on habdelra:114-mark-callable-contracts-false-positive into ca9d6e5 on protofire:master.

@fvictorio
Copy link
Contributor

Hi @habdelra, thanks a lot for the PR!

I pushed a couple of commits more (one for adding more tests, and another one for renaming a variable that had a weird name). Neither of those had to do with your changes, but they won't hurt.

My only question is about the changes in package-lock.json, since you didn't modify package.json. Can we not include those changes?

@habdelra
Copy link
Contributor Author

sure no prob

@fvictorio fvictorio self-requested a review May 14, 2019 14:09
@fvictorio fvictorio merged commit 0d322c7 into protofire:master May 14, 2019
@fvictorio
Copy link
Contributor

Merged. Thanks @habdelra!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fvictorio fvictorio fvictorio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mark-callable-contracts rule is firing a false positive on structs
3 participants
@habdelra @coveralls @fvictorio